Skip to content

Commit fc38e1d

Browse files
authored
Loosen version check requirements (#342)
* Loosen version requirements * lint * lint
1 parent 89de93f commit fc38e1d

File tree

5 files changed

+10
-13
lines changed

5 files changed

+10
-13
lines changed

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@apphosting/adapter-angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@apphosting/adapter-angular",
3-
"version": "17.2.14",
3+
"version": "17.2.15",
44
"main": "dist/index.js",
55
"description": "Experimental addon to the Firebase CLI to add web framework support",
66
"repository": {

packages/@apphosting/adapter-angular/src/bin/build.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,19 @@ const opts = getBuildOptions();
1212

1313
// Check build conditions, which vary depending on your project structure (standalone or monorepo)
1414
await checkBuildConditions(opts);
15-
if (!process.env.FRAMEWORK_VERSION) {
16-
throw new Error("Could not find the angular version of the application");
17-
}
1815

1916
// enable JSON build logs for application builder
2017
process.env.NG_BUILD_LOGS_JSON = "1";
2118
const { stdout: output } = await runBuild();
2219
if (!output) {
2320
throw new Error("No output from Angular build command, expecting a build manifest file.");
2421
}
22+
23+
const angularVersion = process.env.FRAMEWORK_VERSION || "unspecified";
2524
if (!outputBundleExists()) {
2625
const outputBundleOptions = parseOutputBundleOptions(output);
2726
const root = process.cwd();
28-
await generateBuildOutput(root, outputBundleOptions, process.env.FRAMEWORK_VERSION);
27+
await generateBuildOutput(root, outputBundleOptions, angularVersion);
2928

3029
await validateOutputDirectory(outputBundleOptions);
3130
}

packages/@apphosting/adapter-nextjs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@apphosting/adapter-nextjs",
3-
"version": "14.0.13",
3+
"version": "14.0.14",
44
"main": "dist/index.js",
55
"description": "Experimental addon to the Firebase CLI to add web framework support",
66
"repository": {

packages/@apphosting/adapter-nextjs/src/bin/build.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ const opts = getBuildOptions();
1818
process.env.NEXT_PRIVATE_STANDALONE = "true";
1919
// Opt-out sending telemetry to Vercel
2020
process.env.NEXT_TELEMETRY_DISABLED = "1";
21-
if (!process.env.FRAMEWORK_VERSION) {
22-
throw new Error("Could not find the nextjs version of the application");
23-
}
2421

2522
const originalConfig = await loadConfig(root, opts.projectDirectory);
2623

@@ -57,12 +54,13 @@ await addRouteOverrides(
5754
adapterMetadata,
5855
);
5956

57+
const nextjsVersion = process.env.FRAMEWORK_VERSION || "unspecified";
6058
await generateBuildOutput(
6159
root,
6260
opts.projectDirectory,
6361
outputBundleOptions,
6462
nextBuildDirectory,
65-
process.env.FRAMEWORK_VERSION,
63+
nextjsVersion,
6664
adapterMetadata,
6765
);
6866
await validateOutputDirectory(outputBundleOptions, nextBuildDirectory);

0 commit comments

Comments
 (0)