Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Commit c4ac69f

Browse files
author
Jacob Wenger
authored
Renames for Cloud Storage for Firebase (#921)
1 parent bda426d commit c4ac69f

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

docs/guide/uploading-downloading-binary-content.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ Firebase provides [a hosted binary storage service](https://firebase.google.com/
1414
which enables you to store and retrieve user-generated content like images, audio, and
1515
video directly from the Firebase client SDK.
1616

17-
Binary files are stored in a Firebase Storage bucket, not in the Realtime Database.
17+
Binary files are stored in a Cloud Storage bucket, not in the Realtime Database.
1818
The files in your bucket are stored in a hierarchical structure, just like
1919
in the Realtime Database.
2020

21-
To use the Firebase Storage binding, first [create a Firebase Storage reference](https://firebase.google.com/docs/storage/web/create-reference).
21+
To use the Cloud Storage for Firebase binding, first [create a Storage reference](https://firebase.google.com/docs/storage/web/create-reference).
2222
Then, using this reference, pass it into the `$firebaseStorage` service:
2323

2424
```js
@@ -31,7 +31,7 @@ angular
3131

3232
// inject $firebaseStorage into our controller
3333
function SampleCtrl($firebaseStorage) {
34-
// create a Firebase Storage Reference for the $firebaseStorage binding
34+
// create a Storage reference for the $firebaseStorage binding
3535
var storageRef = firebase.storage().ref("userProfiles/physicsmarie");
3636
var storage = $firebaseStorage(storageRef);
3737
}
@@ -40,7 +40,7 @@ SampleCtrl.$inject = ["$firebaseStorage"];
4040

4141
## API Summary
4242

43-
The Firebase Storage service is created with several special `$` methods, all of which are listed in the following table:
43+
The Cloud Storage for Firebase service is created with several special `$` methods, all of which are listed in the following table:
4444

4545
| Method | Description |
4646
| ------------- | ------------- |
@@ -59,7 +59,7 @@ return an [[`UploadTask`](/docs/reference.md#upload-task)(https://firebase.googl
5959

6060
```js
6161
function SampleCtrl($firebaseStorage) {
62-
// create a Firebase Storage Reference for the $firebaseStorage binding
62+
// create a Storage reference for the $firebaseStorage binding
6363
var storageRef = firebase.storage().ref('userProfiles/physicsmarie');
6464
var storage = $firebaseStorage(storageRef);
6565
var file = // get a file from the template (see Retrieving files from template section below)

docs/reference.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ app.config(function() {
8080
apiKey: "<API_Key>", // Your Firebase API key
8181
authDomain: "<AUTH_DOMAIN>", // Your Firebase Auth domain ("*.firebaseapp.com")
8282
databaseURL: "<DATABASE_URL>", // Your Firebase Database URL ("https://*.firebaseio.com")
83-
storageBucket: "<STORAGE_BUCKET>" // Your Firebase Storage bucket ("*.appspot.com")
83+
storageBucket: "<STORAGE_BUCKET>" // Your Cloud Storage for Firebase bucket ("*.appspot.com")
8484
};
8585
firebase.initializeApp(config);
8686
});
@@ -988,7 +988,7 @@ section of our AngularFire guide for more information and a full example.
988988
AngularFire includes support for [binary storage](/docs/guide/uploading-downloading-binary-content.md)
989989
with the `$firebaseStorage` service.
990990

991-
The `$firebaseStorage` service takes a [Firebase Storage](https://firebase.google.com/docs/storage/) reference.
991+
The `$firebaseStorage` service takes a [Storage](https://firebase.google.com/docs/storage/) reference.
992992

993993
```js
994994
app.controller("MyCtrl", ["$scope", "$firebaseStorage",

src/storage/FirebaseStorage.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
}
4545

4646
/**
47-
* Take an Firebase Storage snapshot and unwrap only the needed properties.
47+
* Take a Storage snapshot and unwrap only the needed properties.
4848
*
4949
* @param snapshot
5050
* @returns An object containing the unwrapped values.
@@ -62,20 +62,19 @@
6262
}
6363

6464
/**
65-
* Determines if the value passed in is a Firebase Storage Reference. The
65+
* Determines if the value passed in is a Storage Reference. The
6666
* put method is used for the check.
6767
*
6868
* @param value
69-
* @returns A boolean that indicates if the value is a Firebase Storage
70-
* Reference.
69+
* @returns A boolean that indicates if the value is a Storage Reference.
7170
*/
7271
function _isStorageRef(value) {
7372
value = value || {};
7473
return typeof value.put === 'function';
7574
}
7675

7776
/**
78-
* Checks if the parameter is a Firebase Storage Reference, and throws an
77+
* Checks if the parameter is a Storage Reference, and throws an
7978
* error if it is not.
8079
*
8180
* @param storageRef

tests/unit/FirebaseStorage.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ describe('$firebaseStorage', function () {
292292
});
293293

294294
/**
295-
* A Mock for Firebase Storage Tasks. It has the same .on() method signature
295+
* A Mock for Cloud Storage for Firebase tasks. It has the same .on() method signature
296296
* but it simply stores the callbacks without doing anything. To make something
297297
* happen you call the makeProgress(), causeError(), or complete() methods. The
298298
* empty methods are intentional noops.

0 commit comments

Comments
 (0)