-
-
Notifications
You must be signed in to change notification settings - Fork 180
Closed
Labels
good first issueIssue that seems easy to resolve and is likely a good candidate for contributors new to projectIssue that seems easy to resolve and is likely a good candidate for contributors new to projecthacktoberfestIssue related to Hactoberfest2020 activities, eligible for additional rewardsIssue related to Hactoberfest2020 activities, eligible for additional rewards
Milestone
Description
Since Jackson does not require Java 9 (or higher baseline), module system can not be used to create module-info.class
.
But most Jackson components/modules are using Moditect (https://github.com/moditect/moditect) -- support added in 2.11 -- to produce necessary metadata even when building using Java 8 tools.
It would be good to add necessary build support to Kotlin module too.
This issue:
FasterXML/jackson-databind#2273
can show what is needed; basic addition would be:
- Add
src/moditect/module-info.java
with dependency definitions (see Joda module's file, f.ex: https://github.com/FasterXML/jackson-datatype-joda/blob/2.12/src/moditect/module-info.java ) - Add plugin invocation in
pom.xml
(see https://github.com/FasterXML/jackson-datatype-joda/blob/2.12/pom.xml#L106 )
with appropriate modifications -- mostly, need to know Kotlin core module's JPMS coordinates.
Metadata
Metadata
Assignees
Labels
good first issueIssue that seems easy to resolve and is likely a good candidate for contributors new to projectIssue that seems easy to resolve and is likely a good candidate for contributors new to projecthacktoberfestIssue related to Hactoberfest2020 activities, eligible for additional rewardsIssue related to Hactoberfest2020 activities, eligible for additional rewards