diff --git a/src/Two-3Dpose-Estimator/data/prepare_data_2d_h36m_sh.py b/src/Two-3Dpose-Estimator/data/prepare_data_2d_h36m_sh.py index 0d706d6..a17ae56 100644 --- a/src/Two-3Dpose-Estimator/data/prepare_data_2d_h36m_sh.py +++ b/src/Two-3Dpose-Estimator/data/prepare_data_2d_h36m_sh.py @@ -87,7 +87,26 @@ def process_subject(subject, file_list, output): print('Converting fine-tuned dataset from', args.fine_tuned) print('Extracting...') with tarfile.open(args.fine_tuned, 'r:gz') as archive: - archive.extractall('sh_ft') + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(archive, "sh_ft") print('Converting...') output = {} diff --git a/src/VideoPose3D/data/prepare_data_2d_h36m_sh.py b/src/VideoPose3D/data/prepare_data_2d_h36m_sh.py index b4c8642..53bac6f 100644 --- a/src/VideoPose3D/data/prepare_data_2d_h36m_sh.py +++ b/src/VideoPose3D/data/prepare_data_2d_h36m_sh.py @@ -94,7 +94,26 @@ def process_subject(subject, file_list, output): print('Converting fine-tuned dataset from', args.fine_tuned) print('Extracting...') with tarfile.open(args.fine_tuned, 'r:gz') as archive: - archive.extractall('sh_ft') + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(archive, "sh_ft") print('Converting...') output = {}