Skip to content

Commit 810a76b

Browse files
committed
Revert "don't trace through functions that capture values (sizeof != 0) or BroadcastFunction"
This reverts commit 364c9b9.
1 parent 12b689e commit 810a76b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/utils.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -848,13 +848,13 @@ function call_with_reactant_generator(
848848
match.sparams,
849849
)
850850
method = mi.def
851-
Core.println("Found method from module $(method.module) with name $(method.name), TRACE_CALLS[] = $(TRACE_CALLS[])")
851+
Core.println("Found method from module $(method.module) with name $(method.name)")
852852
trace_call_within = TRACE_CALLS[] && !(
853853
has_ancestor(method.module, Reactant.TracedRNumberOverrides) ||
854854
has_ancestor(method.module, Reactant.TracedRArrayOverrides) ||
855855
has_ancestor(method.module, Core)
856856
)
857-
if TRACE_CALLS[] && !(sizeof(fn) != 0 || fn <: Base.BroadcastFunction)
857+
if TRACE_CALLS[]
858858
Core.println("About to trace call to $fn.")
859859
else
860860
Core.println("Not tracing call to $fn.")
@@ -1044,7 +1044,7 @@ function call_with_reactant_generator(
10441044
res = push_inst!(rep)
10451045
end
10461046
# ocres = if should_trace_call && sizeof(typeof(fn)) != 0 || fn isa Base.BroadcastFunction
1047-
ocres = if TRACE_CALLS[] && !(sizeof(fn) != 0 || fn <: Base.BroadcastFunction)
1047+
ocres = if TRACE_CALLS[]
10481048
push!(code_info.slotnames, :tryfinallystate)
10491049
push!(code_info.slotflags, zero(UInt8))
10501050
tryfinally_slot = Core.SlotNumber(length(code_info.slotnames))

0 commit comments

Comments
 (0)