Add tests #235
Open
Add tests #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-e
commented
Apr 30, 2025
| ), | ||
| .testTarget( | ||
| name: "SnapshotPreviewsTests", | ||
| dependencies: ["SnapshotPreviewsCore", "SnapshotPreferences"] |
There was a problem hiding this comment.
I reformatted this file via swiftlint (can revert if you want) and added some dependencies for our testTarget.
trevor-e
commented
Apr 30, 2025
trevor-e
commented
Apr 30, 2025
| } | ||
| } | ||
|
|
||
| private enum RuntimeCache { |
There was a problem hiding this comment.
In order for the tests to work (since the test bundle code loads first), I had to refactor this to lazily initialize after the first access is made.
There was a problem hiding this comment.
Instead of this can we just move these static properties right into EmergeModifierView? Would be better not to have new types like this.
Also I think the finderClass can still be it's own static variable so that line doesn't have to be duplicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.