Fix globalUsername being set to true and thus not being checked correctly during authentication

Jordan Hall · Jordan Hall · commit 054a161440a0 · 2017-03-29T11:55:56.000+01:00
diff --git a/src/Http/Middleware/BasicAuthentication.php b/src/Http/Middleware/BasicAuthentication.php
@@ -86,7 +86,7 @@ protected function validate($request, $user, $password, $routeUsername = null, $
             }
         }
         // Check if global username and password are set
-        elseif ($globalUsername = config('laravel-route-restrictor.global.username') && $globalPassword = config('laravel-route-restrictor.global.password')) {
+        elseif (($globalUsername = config('laravel-route-restrictor.global.username')) && ($globalPassword = config('laravel-route-restrictor.global.password'))) {
             
             // Check against global password
             if (trim($user) == $globalUsername && trim($password) == $globalPassword) {

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ protected function validate($request, $user, $password, $routeUsername = null, $`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`	`// Check if global username and password are set`
`89`		`- elseif ($globalUsername = config('laravel-route-restrictor.global.username') && $globalPassword = config('laravel-route-restrictor.global.password')) {`
	`89`	`+ elseif (($globalUsername = config('laravel-route-restrictor.global.username')) && ($globalPassword = config('laravel-route-restrictor.global.password'))) {`
`90`	`90`
`91`	`91`	`// Check against global password`
`92`	`92`	`if (trim($user) == $globalUsername && trim($password) == $globalPassword) {`