Skip to content

Commit f494d85

Browse files
author
devsh
committed
yes NBL_EMBED_BUILTIN_RESOURCES should control both Nable and examples_tests w.r.t. the question of MonoAssetManagerAndBuiltinResourceApplication.hpp
There really isn't a usecase for: - embedding Nabla resources but not embedding example (there's no harm in Nabla resources not being embedded) - even more strangely, not embedding Nabla resources, but embedding example.
1 parent a0622f3 commit f494d85

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

common/include/nbl/examples/PCH.hpp

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,8 @@
1515

1616
//! Common example interface headers
1717

18-
// why isnt this in `nabla.h` ?
19-
/*
20-
because it does stuff like
21-
22-
#ifdef NBL_EMBED_BUILTIN_RESOURCES
23-
#include "nbl/this_example/builtin/CArchive.h"
24-
#endif
25-
26-
hence also cannot be there in PCH but rather in examples.h -> compile errors
27-
but only *if* we decide each example handles builtins on NBL_EMBED_BUILTIN_RESOURCES
28-
*/
29-
// #include "nbl/application_templates/MonoAssetManagerAndBuiltinResourceApplication.hpp"
18+
// TODO: examine moving this header to `nbl/examples/common`
19+
#include "nbl/application_templates/MonoAssetManagerAndBuiltinResourceApplication.hpp"
3020

3121
#include "nbl/examples/common/SimpleWindowedApplication.hpp"
3222
#include "nbl/examples/common/MonoWindowApplication.hpp"

0 commit comments

Comments
 (0)