feat(actions): enhance group selection logic for edit actions and update tests

Author: PierreRaybaut

src/App.tsx

@@ -3683,6 +3683,7 @@ export default function App() {
       hasNotebooks: notebookCount > 0,
       hasMetadataClipboard,
       selectionHasRoi,
+      selectedGroupCount: selectedGroupIds.length,
     }),
     [
       status,
@@ -3694,6 +3695,7 @@ export default function App() {
       notebookCount,
       hasMetadataClipboard,
       selectionHasRoi,
+      selectedGroupIds,
     ],
   );
 

src/actions/registry.ts

@@ -213,7 +213,13 @@ export function buildStaticActions(
       menuPath: "Edit/Rename",
       iconUrl: getEditIconUrl("rename.svg"),
       beginGroup: true,
-      enabled: (s) => ready(s) && s.currentId !== null,
+      // Mirror DataLab desktop's ``SelectCond.exactly_one_group_or_one_object``:
+      // a single group, or a single object (with no group) — selecting a group
+      // populates ``selectedIds`` with its children, so check the group count.
+      enabled: (s) =>
+        ready(s) &&
+        (s.selectedGroupCount === 1 ||
+          (s.selectedGroupCount === 0 && s.selectedIds.length === 1)),
       run: cb.onRenameCurrent,
     },
     {
@@ -570,11 +576,13 @@ export function buildAIAssistantActions(
  * | pattern   | meaning                       | requirement beyond a selection |
  * | --------- | ----------------------------- | ------------------------------ |
  * | ``1_to_1``| one object → one object       | none                           |
- * | ``n_to_1``| n objects → one object        | none (operates on the set)     |
+ * | ``n_to_1``| n objects → one object        | at least two selected objects  |
  * | ``2_to_1``| object + operand → one object | a second object must exist     |
  *
  * Every pattern first needs the runtime ready, not busy, and at least one
- * selected or current object. Keep this in sync with ``processor.py`` when a
+ * selected or current object. ``n_to_1`` aggregations (Sum, Average, …) are
+ * only meaningful on two or more objects, mirroring DataLab desktop's
+ * ``SelectCond.at_least_two``. Keep this in sync with ``processor.py`` when a
  * new pattern is introduced.
  */
 export function isFeatureActionEnabled(
@@ -583,6 +591,8 @@ export function isFeatureActionEnabled(
 ): boolean {
   if (s.status !== "ready" || s.busy) return false;
   if (s.selectedIds.length === 0 && !s.currentId) return false;
+  // ``n_to_1`` aggregations need at least two objects to combine.
+  if (pattern === "n_to_1") return s.selectedIds.length >= 2;
   // ``2_to_1`` needs a second operand object to combine with the selection.
   if (pattern === "2_to_1") return s.hasObjects;
   return true;

src/actions/types.ts

@@ -13,6 +13,12 @@ export interface ActionState {
   selectedIds: string[];
   currentId: string | null;
   hasObjects: boolean;
+  /** Number of currently selected groups. Mirrors DataLab desktop's
+   *  group selection, which is exclusive with object selection. Used to
+   *  reproduce ``SelectCond.exactly_one_group_or_one_object`` (Rename),
+   *  where a single selected group counts as one target even though its
+   *  child object ids populate ``selectedIds``. */
+  selectedGroupCount: number;
   /** ``true`` when at least one macro is loaded in the workspace. */
   hasMacros: boolean;
   /** ``true`` when at least one notebook is loaded in the workspace. */

tests/ts/actions/registry.test.ts

@@ -23,6 +23,7 @@ function makeState(over: Partial<ActionState> = {}): ActionState {
     hasNotebooks: false,
     hasMetadataClipboard: false,
     selectionHasRoi: false,
+    selectedGroupCount: 0,
     ...over,
   };
 }
@@ -85,6 +86,29 @@ describe("buildStaticActions", () => {
     expect(del.enabled(makeState({ selectedIds: ["x"] }))).toBe(true);
   });
 
+  it("enables ``edit.rename`` only for a single object or a single group", () => {
+    const actions = buildStaticActions(makeStaticCallbacks());
+    const rename = actions.find((a) => a.id === "edit.rename")!;
+    // Nothing selected — disabled.
+    expect(rename.enabled(makeState())).toBe(false);
+    // Exactly one object (no group) — enabled.
+    expect(rename.enabled(makeState({ selectedIds: ["a"] }))).toBe(true);
+    // Several objects selected — disabled (mirrors desktop exactly_one).
+    expect(rename.enabled(makeState({ selectedIds: ["a", "b"] }))).toBe(false);
+    // A single group (its children populate ``selectedIds``) — enabled.
+    expect(
+      rename.enabled(
+        makeState({ selectedIds: ["a", "b"], selectedGroupCount: 1 }),
+      ),
+    ).toBe(true);
+    // Two groups selected — disabled.
+    expect(
+      rename.enabled(
+        makeState({ selectedIds: ["a", "b"], selectedGroupCount: 2 }),
+      ),
+    ).toBe(false);
+  });
+
   it("enables ``file.save_workspace_h5`` for any persistable content", () => {
     const actions = buildStaticActions(makeStaticCallbacks());
     const save = actions.find((a) => a.id === "file.save_workspace_h5")!;
@@ -240,10 +264,23 @@ describe("isFeatureActionEnabled", () => {
     );
   });
 
-  it("enables 1-to-1 and n-to-1 as soon as something is selected", () => {
+  it("enables 1-to-1 as soon as something is selected", () => {
     const sel = makeState({ currentId: "a" });
     expect(isFeatureActionEnabled("1_to_1", sel)).toBe(true);
-    expect(isFeatureActionEnabled("n_to_1", sel)).toBe(true);
+  });
+
+  it("requires at least two selected objects for n-to-1 features", () => {
+    // A single selection (current or one selected id) is not enough:
+    // aggregations like Sum/Average/Product need two or more objects.
+    expect(
+      isFeatureActionEnabled("n_to_1", makeState({ currentId: "a" })),
+    ).toBe(false);
+    expect(
+      isFeatureActionEnabled("n_to_1", makeState({ selectedIds: ["a"] })),
+    ).toBe(false);
+    expect(
+      isFeatureActionEnabled("n_to_1", makeState({ selectedIds: ["a", "b"] })),
+    ).toBe(true);
   });
 });