Fix flaky sampler spec

Author: Strech

spec/datadog/appsec/api_security/lru_cache_spec.rb

@@ -47,15 +47,15 @@
     let(:lru_cache) { described_class.new(3) }
 
     it 'stores a key-value pair' do
-      expect { lru_cache.store(:key, 'value') }.to
-        change { lru_cache[:key] }.from(nil).to('value')
+      expect { lru_cache.store(:key, 'value') }.to change { lru_cache[:key] }
+        .from(nil).to('value')
     end
 
     it 'overwrites existing values' do
       lru_cache.store(:key, 'old-value')
 
-      expect { lru_cache.store(:key, 'new-value') }.to
-        change { lru_cache[:key] }.from('old-value').to('new-value')
+      expect { lru_cache.store(:key, 'new-value') }.to change { lru_cache[:key] }
+        .from('old-value').to('new-value')
     end
 
     context 'when maximum size is reached' do

spec/datadog/appsec/api_security/sampler_spec.rb

@@ -19,12 +19,18 @@
       example.run
     ensure
       Datadog.configuration.reset!
+      described_class.reset!
     end
 
     context 'when called for the first time' do
       it 'returns a new sampler instance' do
-        expect { described_class.thread_local }.to change { Thread.current.thread_variable_get(:__sampler_key__) }
-          .from(nil).to(be_a(described_class))
+        # NOTE: Isolating the sampler in a separate thread to avoid flakiness
+        thread = Thread.new do
+          expect { described_class.thread_local }.to change { Thread.current.thread_variable_get(:__sampler_key__) }
+            .from(nil).to(be_a(described_class))
+        end
+
+        thread.join
       end
     end