forked from foundry-rs/foundry
-
Notifications
You must be signed in to change notification settings - Fork 1
Open
1 / 31 of 3 issues completedOpen
1 / 31 of 3 issues completed
Copy link
Labels
P-highT-bugdependenciesPull requests that update a dependency filePull requests that update a dependency filedocumentationImprovements or additions to documentationImprovements or additions to documentationgithub_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions codegood first issueGood for newcomersGood for newcomers
Description
Reviewer's Guide
This PR enriches the documentation pipeline by adding variant‐table support, refactors provider‐selection and sorting routines to use more robust pattern and comparison methods, applies a minor regex fix for test redactions, adds missing comment‐conversion helpers, bumps a dependency, and layers in comprehensive CI scaffolding—including multiple GitHub workflows, issue templates, and a new “counter” example project.
Entity relationship diagram for Counter contract storage
erDiagram
COUNTER {
uint256 number
}
Class diagram for new and updated documentation writer types
classDiagram
class BufWriter {
+try_write_variant_table(params: EnumDefinition, comments: Comments)
+try_write_properties_table(params, comments)
+try_write_events_table(params, comments)
}
class Comments {
+From<Vec<Comment>>
}
class EnumDefinition {
values
}
class Comment {
tag
match_first_word(name)
}
BufWriter --> EnumDefinition
BufWriter --> Comments
Comments <|-- Comment
EnumDefinition "1" -- "*" Comment : values
Class diagram for Counter Solidity contract
classDiagram
class Counter {
+number: uint256
+setNumber(newNumber: uint256)
+increment()
}
Class diagram for CounterScript Solidity contract
classDiagram
class CounterScript {
+counter: Counter
+setUp()
+run()
}
CounterScript --> Counter
File-Level Changes
| Change | Details | Files |
|---|---|---|
| Add variant table rendering in documentation |
|
crates/doc/src/writer/buf_writer.rscrates/doc/src/writer/as_doc.rs |
| Refactor VerificationProviderType to use matches! macros and simplify key checks |
|
crates/verify/src/provider.rs |
| Standardize comparisons to use partial_cmp with unwrap fallback |
|
crates/forge/src/cmd/snapshot.rscrates/cli/src/utils/suggestions.rscrates/common/src/contracts.rs |
| Adjust test redactions to expect ETH symbol |
|
crates/test-utils/src/util.rs |
| Add missing Comments conversion helper and minor syntax fixes |
|
crates/doc/src/parser/comment.rs |
| Bump dependency and add CI/workflow scaffolding with example project |
|
Cargo.toml.github/workflows/nextest.yml.github/workflows/codeql.yml.github/workflows/jekyll.ymlcounter/.github/workflows/test.yml.github/workflows/docker-image.yml.github/ISSUE_TEMPLATE/bug_report.md.github/ISSUE_TEMPLATE/feature_request.md.github/ISSUE_TEMPLATE/custom.md.circleci/config.yml.github/workflows/apisec-scan.yml.deps/remix-tests/remix_tests.sol.deps/remix-tests/remix_accounts.solcounter/README.mdcounter/test/Counter.t.solcounter/script/Counter.s.solcounter/src/Counter.solcounter/foundry.toml |
Tips and commands
Interacting with Sourcery
- Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
- Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with@sourcery-ai issueto create an issue from it. - Generate a pull request title: Write
@sourcery-aianywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai titleon the pull request to (re-)generate the title at any time. - Generate a pull request summary: Write
@sourcery-ai summaryanywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment@sourcery-ai summaryon the pull request to
(re-)generate the summary at any time. - Generate reviewer's guide: Comment
@sourcery-ai guideon the pull
request to (re-)generate the reviewer's guide at any time. - Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore. - Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai reviewto trigger a new review!
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others. - Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.
Originally posted by @sourcery-ai[bot] in #145 (comment)
Sub-issues
Metadata
Metadata
Assignees
Labels
P-highT-bugdependenciesPull requests that update a dependency filePull requests that update a dependency filedocumentationImprovements or additions to documentationImprovements or additions to documentationgithub_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions codegood first issueGood for newcomersGood for newcomers
Projects
Status
Backlog
Status
Todo