Possible bug when applying changes

[sash-a]

Hi there, thanks for this plugin, it's great! I have an issue when making full file edits though. It seems that when accepting a diff I often get syntax issues like the intended edit should've deleted more code. For example when using this prompt for this file

#file:mava/systems/ppo/anakin/ff_mappo.py

Please make this file more readable, specifically by reducing the nesting

It gets the edits correct, by refactoring the deeply nested functions, however when applying the edits with C-y it seems to start the edits from this line which is the first line you would refactor, but it causes a syntax error because it should have deleted the lines above also.

I'm wondering if this is an issue with model, the plugin or something else?

For reference I'm using the default config provided in LazyVim and I've tested both ChatGPT-4o and Claude-3.7

[deathbeam]

I just tried this and got mostly correct response (in 2 separate diffs). But sometimes the models get line off by 1 or get confused and im not doing any diff corrections in the plugin either. Also when applying diffs make sure to apply them from end to start instead of the other way around to prevent line numbers changing for the later diffs.

[greyHairChooseLife]

"Also when applying diffs make sure to apply them from end to start"

I think this line would be better placed in the README. Owner and collaborators have been doing excellent job, so users might assume it is a limitation of Copilot rather than an intentional approach - at least, that's what I thought.

And I guess we could potentially use the callback function of the accept_diff keymap to update line numbers of diffs dynamically.

Thank you, everyone, for all your contributions in this community.

[deathbeam]

well its mostly limitation of the format we use, but yea its def intentional. alternatives are using git unified diffs, but that is way more confusing when presenting the changes in chat so line numbered replacements work well enough. But also because someone else also had this issue recently, you can try enabling full_diff in the show_diff mapping. THis one collects all the diffs bottom to top in closest answer and displays actual vim diff with the changes so applying bunch of changes at once is a lot nicer with it imo