Skip to content

Preview link in passenger showcase guide #702

Open
@DenisovichDev

Description

@DenisovichDev

Under SUBMITTING A PULL REQUEST I think it's worth mentioning that in the description of the PR it's good to have a preview link. Since we don't have that template thing like we did in the old repo anymore.

I think this screenshot could have a preview link or picture:
image

Activity

shiffman

shiffman commented on Oct 21, 2022

@shiffman
Member

Good call! I'm also not opposed to adding templates for issues and pull requests if you have ideas on what would be most helpful to the community!

DenisovichDev

DenisovichDev commented on Oct 22, 2022

@DenisovichDev
MemberAuthor

@shiffman I can work on some templates for PR and issues if you like! I think something minimal would be the best.
I'll get working on the edits to be made in the guide for now then.

shiffman

shiffman commented on Oct 22, 2022

@shiffman
Member

Sounds great! The reason I am slow to do this one and #628 is changing the screenshots maybe requires doing all of them so that they have the same look and feel?

DenisovichDev

DenisovichDev commented on Oct 22, 2022

@DenisovichDev
MemberAuthor

Yes I have that in my mind. I can try make it look similar with a bit of editing. And if it doesn't look very good at the end, we can keep it in hold while we get the screenshots ready for it. There's no rush anyway

dipamsen

dipamsen commented on Oct 24, 2022

@dipamsen
Member

For PR Templates, I think the following versions are possible:

  • Porting a Track
  • Porting a Challenge
  • Showcase Submission
shiffman

shiffman commented on Oct 24, 2022

@shiffman
Member

Agreed! This is a tiny point but I think we can consider them "Creating a Track" or "Creating a Challenge Page" since it ultimately is less about porting and more about making the content for the site! Also, we are close to getting all of the older challenges done so I'm not sure how much longer that will be relevant! (There are probably so many ways that side tracks can be configured).

dipamsen

dipamsen commented on Oct 24, 2022

@dipamsen
Member

That is true!

DenisovichDev

DenisovichDev commented on Oct 24, 2022

@DenisovichDev
MemberAuthor

Ah thank you @dipamsen!

shiffman

shiffman commented on Dec 2, 2024

@shiffman
Member

Is this still a valid issue? It's been 2 years now so I'm not sure if it's still relevant given where we are with the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentationhelp wantedExtra attention is needed

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Preview link in passenger showcase guide · Issue #702 · CodingTrain/thecodingtrain.com