Merge pull request #1656 from fturmel/PR/improve-content-testing-videoId

Improve content test for `videoId` field

Author: shiffman

content-testing/schemas.js

@@ -21,9 +21,15 @@ const baseVideosSchema = strictObject({
   title: string().required(),
   description: string().required(),
 
-  videoId: youtubeIdValidator.when(['parts'], (parts, schema) => {
+  videoId: youtubeIdValidator.when('parts', ([parts], schema) => {
     // videoId required if the `parts` array is missing or empty
-    return parts && parts.length > 0 ? schema : schema.required();
+    return parts && parts.length > 0
+      ? schema.test(
+          'videoId and parts conflict',
+          'Top-level "videoId" should not be defined if "parts" exist',
+          (value) => value === undefined
+        )
+      : schema.required();
   }),
 
   nebulaSlug: nonUrlStringValidator,

content/videos/challenges/10-dfs-maze-generator/index.json

@@ -2,7 +2,6 @@
   "title": "Maze Generator",
   "description": "Choo choo! In this multi-part coding challenge, I create a maze generator using a depth-first search algorithm with recursive backtracking. The idea is to walk through a grid of cells, removing walls as we go to build a maze.",
   "videoNumber": "10",
-  "videoId": "",
   "date": "2016-05-02",
   "languages": ["p5.js", "JavaScript"],
   "topics": ["maze", "recursion", "backtracking", "depth-first search"],

content/videos/challenges/100-neuroevolution-flappy-bird/index.json

@@ -2,7 +2,6 @@
   "title": "Neuroevolution Flappy Bird",
   "description": "In this challenge, I use my JavaScript neural network library and a genetic algorithm to train an agent to play Flappy Bird.",
   "videoNumber": "100",
-  "videoId": "c6y21FkaUqw",
   "date": "2018-04-16",
   "languages": ["JavaScript", "p5.js"],
   "topics": ["neural network", "reinforcement learning", "genetic algorithms", "evolution", "Flappy Bird game"],

content/videos/challenges/110-recamans-sequence/index.json

@@ -2,7 +2,6 @@
   "title": "Recamán's Sequence",
   "description": "In this coding challenge, I visualize the Recamán’s number sequence using the p5.js library and go on to generate a series of musical tones using p5.js sound.",
   "videoNumber": "110",
-  "videoId": "",
   "date": "2018-07-24",
   "languages": ["p5.js", "JavaScript"],
   "topics": ["number sequence", "Recamán's sequence", "music", "audio-visual", "visualization"],

content/videos/challenges/121-logo-interpreter/index.json

@@ -2,7 +2,6 @@
   "title": "Logo Interpreter",
   "description": "In this coding challenge, I discuss turtle graphics and make a Logo Interpreter in JavaScript.",
   "videoNumber": "121",
-  "videoId": "",
   "date": "2018-10-31",
   "languages": ["p5.js", "JavaScript"],
   "topics": ["Logo", "Logo interpreter", "turtle graphics"],

content/videos/challenges/122-quick-draw/index.json

@@ -2,7 +2,6 @@
   "title": "Quick, Draw!",
   "description": "In this multi-part coding challenge, I take a closer look at the Quick, Draw! dataset and create a simple node API to \"replay\" drawings of rainbows and cats using p5.js.",
   "videoNumber": "122",
-  "videoId": "",
   "date": "2018-11-19",
   "languages": ["p5.js", "Node.js", "JavaScript"],
   "topics": ["Quick, Draw! game", "machine learning (ML)", "doodle classifiers", "sketch-RNN"],

content/videos/challenges/123-chaos-game/index.json

@@ -2,7 +2,6 @@
   "title": "Chaos Game",
   "description": "In this multi-part coding challenge, I visualize the \"Chaos Game\".",
   "videoNumber": "123",
-  "videoId": "",
   "date": "2018-11-29",
   "languages": ["p5.js", "JavaScript"],
   "topics": ["chaos game", "fractal", "seed points", "probability"],

content/videos/challenges/130-drawing-with-fourier-transform-and-epicycles/index.json

@@ -2,7 +2,6 @@
   "title": "Drawing with Fourier Transform and Epicycles",
   "description": "In this coding challenge, I implement the Discrete Fourier Transform algorithm in JavaScript and render a drawing using epicycles derived from the transform.",
   "videoNumber": "130",
-  "videoId": "MY4luNgGfms",
   "date": "2019-01-24",
   "languages": ["JavaScript", "p5.js"],
   "topics": ["Fourier transform square wave", "discrete Fourier transform", "epicycles drawing"],

content/videos/challenges/134-heart-curve/index.json

@@ -2,7 +2,6 @@
   "title": "Heart Curve",
   "description": "In this multi-part challenge, I use a parametric equation (from Wolfram Mathworld) to draw a heart curve in Processing (Java).",
   "videoNumber": "134",
-  "videoId": "",
   "date": "2019-02-18",
   "languages": ["Processing"],
   "topics": ["heart curve", "parametric equation", "polar coordinates", "GIF loop"],

content/videos/challenges/136-polar-noise-loops/index.json

@@ -2,7 +2,6 @@
   "title": "Polar Noise Loops",
   "description": "In this multi-part coding challenge I show how to use a noise field and polar coordinates to create a perfect GIF loop.",
   "videoNumber": "136",
-  "videoId": "",
   "date": "2019-02-25",
   "languages": ["p5.js", "Processing"],
   "topics": ["GIF loop", "Perlin noise", "polar coordinates"],