Skip to content

Commit 71d0e99

Browse files
author
Loïc Mangeonjean
committed
fix: patch xterm to support shadow dom
1 parent 39a724d commit 71d0e99

File tree

4 files changed

+690
-12
lines changed

4 files changed

+690
-12
lines changed

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,11 @@ There are multiple benefits of using it:
338338

339339
If the provided container element is a child of a shadow dom element, the styles will be injected in both the main page and the shadow root. That's it.
340340

341+
### ⚠️ Xterm notice ⚠️
342+
343+
The webgl renderer of xterm, which VSCode is using, doesn't support being used inside a shadom dom (see https://github.com/xtermjs/xterm.js/pull/5334).
344+
Until it's fixed and deployed, either do not use the terminal service override, or apply the patch on your side (using [patch-package](https://www.npmjs.com/package/patch-package) for instance).
345+
341346
### Prerequisites
342347

343348
In order to be able to load the static css files in the shadow dom as well. Your bundler configuration needs to be adapted so that importing css files doesn't load their content in the page head, but instead just returns the file content as default (either as a string or a `CSSStyleSheet`). It can be achieved with most bundlers with some configurations.

0 commit comments

Comments
 (0)