Skip to content

Commit 15b9717

Browse files
Merge pull request #69 from CodinGame/fix-extension-loading
[FIX] Fix extension loading
2 parents b1afe7c + fc0dc95 commit 15b9717

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

src/extensionConfiguration.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
11
import { loadConfigurationForExtension } from '@codingame/monaco-editor-wrapper/features/extensionConfigurations'
2-
import { getLanguageClientOptions, LanguageClientId } from './languageClientOptions'
2+
import { LanguageClientOptions } from './languageClientOptions'
33

44
/**
55
* Load the configuration schemas from vscode extensions
66
* @param forLanguageClientIds Load the extensions related to these language client ids
77
* @param useMutualizedProxy The language server proxy is used, so we only need to load configurations for language servers which are not mutualized
88
*/
9-
export async function loadExtensionConfigurations (forLanguageClientIds: LanguageClientId[], useMutualizedProxy: boolean): Promise<void> {
9+
export async function loadExtensionConfigurations (clientOptions: LanguageClientOptions[], useMutualizedProxy: boolean): Promise<void> {
1010
const extensionConfigurationToLoad = new Set<string>()
11-
for (const languageClientId of forLanguageClientIds) {
12-
const config = getLanguageClientOptions(languageClientId)
13-
if (!config.mutualizable || !useMutualizedProxy) {
14-
config.vscodeExtensionIds?.forEach(extensionId => {
11+
for (const clientOption of clientOptions) {
12+
if (!clientOption.mutualizable || !useMutualizedProxy) {
13+
clientOption.vscodeExtensionIds?.forEach(extensionId => {
1514
extensionConfigurationToLoad.add(extensionId)
1615
})
1716
}

src/languageClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export class LanguageClientManager implements LanguageClient {
171171

172172
private prepare = once(async () => {
173173
try {
174-
await loadExtensionConfigurations([this.id], this.useMutualizedProxy)
174+
await loadExtensionConfigurations([this.clientOptions], this.useMutualizedProxy)
175175
} catch (error) {
176176
errorHandler.onUnexpectedError(new Error('[LSP] Unable to load extension configuration', {
177177
cause: error as Error

0 commit comments

Comments
 (0)