Merge pull request #16 from CodinGame/fix-eslint-ts-config

Fix eslint ts config

Author: CGNonofr

.eslintrc.js

@@ -4,116 +4,19 @@ module.exports = {
     es6: true
   },
   extends: [
-    'standard', 'standard-jsx'
+    '@codingame', 'standard-jsx'
   ],
-  globals: {
-    Atomics: 'readonly',
-    SharedArrayBuffer: 'readonly'
-  },
-  parser: '@typescript-eslint/parser',
   parserOptions: {
     ecmaFeatures: {
       jsx: true
-    },
-    ecmaVersion: 2018,
-    sourceType: 'module',
-    project: './tsconfig.json'
+    }
   },
   plugins: [
     'react',
-    '@typescript-eslint',
-    'react-hooks',
-    'unused-imports'
+    'react-hooks'
   ],
   rules: {
-    '@typescript-eslint/member-delimiter-style': [
-      'error',
-      {
-        multiline: {
-          delimiter: 'none'
-        },
-        singleline: {
-          delimiter: 'comma'
-        }
-      }
-    ],
-    '@typescript-eslint/no-misused-promises': [
-      'error',
-      { checksVoidReturn: false }
-    ],
-    'no-unused-vars': 'off',
-    '@typescript-eslint/no-unused-vars': ['warn', { ignoreRestSiblings: true }],
-    'no-use-before-define': 'off',
-    '@typescript-eslint/no-use-before-define': [
-      'error',
-      {
-        functions: false,
-        classes: false,
-        variables: false
-      }
-    ],
-    '@typescript-eslint/no-useless-constructor': 'error',
-    '@typescript-eslint/type-annotation-spacing': 'error',
-    'import/named': 'off',
-    'import/namespace': 'off',
-    'import/no-unresolved': 'off',
-    'import/order': [
-      'warn',
-      {
-        groups: ['unknown', 'external', 'internal', 'builtin', 'index', 'sibling', 'parent'],
-        'newlines-between': 'never'
-      }
-    ],
-    'no-console': ['warn', { allow: ['warn', 'error', 'debug', 'info'] }],
-    'no-useless-constructor': 'off',
-    'unused-imports/no-unused-imports': 'warn',
-    'no-redeclare': 'off',
-    '@typescript-eslint/no-redeclare': ['error'],
-    '@typescript-eslint/no-unnecessary-condition': 'warn',
-    '@typescript-eslint/explicit-module-boundary-types': [
-      'warn',
-      {
-        allowArgumentsExplicitlyTypedAsAny: true
-      }
-    ],
-    semi: 'off',
-    '@typescript-eslint/semi': [
-      'error', 'never'
-    ],
-    'eslint/no-extra-semi': 'off',
-    '@typescript-eslint/no-extra-semi': [
-      'warn'
-    ],
-    '@typescript-eslint/strict-boolean-expressions': [
-      'warn',
-      {
-        allowString: false,
-        allowNumber: false,
-        allowNullableObject: false
-      }
-    ],
-    '@typescript-eslint/no-explicit-any': [
-      'error',
-      {
-        ignoreRestArgs: true
-      }
-    ],
-    '@typescript-eslint/no-unnecessary-type-assertion': ['error'],
-    '@typescript-eslint/no-floating-promises': [
-      'error'
-    ],
-    'no-void': [
-      'error',
-      {
-        allowAsStatement: true
-      }
-    ],
-    'react-hooks/exhaustive-deps': [
-      'error',
-      {
-        additionalHooks: '(useDebouncedCallback)'
-      }
-    ],
+    'react-hooks/exhaustive-deps': 'error',
     'react-hooks/rules-of-hooks': 'error'
   }
 }

.github/workflows/check_build.yml

@@ -1,5 +1,8 @@
 name: Check build
-on: [push]
+on:
+  push:
+    branches-ignore:
+      - main
 
 jobs:
   check:

package-lock.json

@@ -3,8 +3,9 @@
   "version": "0.0.0-semantic-release",
   "description": "Monaco Editor React component",
   "scripts": {
-    "build": "tsc",
-    "lint": "npx eslint src/**"
+    "build": "npm run lint && npm run compile",
+    "compile": "tsc",
+    "lint": "npx eslint --ext .ts src"
   },
   "repository": {
     "type": "git",
@@ -30,6 +31,8 @@
     "@babel/preset-react": "7.17.12",
     "@babel/preset-typescript": "7.17.12",
     "@babel/runtime": "7.18.3",
+    "@codingame/eslint-config": "^1.1.2",
+    "@codingame/tsconfig": "^1.0.5",
     "@types/deep-equal": "^1.0.1",
     "@types/react": "18.0.8",
     "@typescript-eslint/eslint-plugin": "5.27.1",
@@ -43,8 +46,7 @@
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-promise": "6.0.0",
     "eslint-plugin-react": "7.30.0",
-    "eslint-plugin-react-hooks": "4.5.0",
-    "eslint-plugin-standard": "5.0.0",
+    "eslint-plugin-react-hooks": "^4.5.0",
     "eslint-plugin-unused-imports": "2.0.0",
     "typescript": "4.7.3"
   },

package.json

@@ -5,7 +5,7 @@ export default function useIsUserActive (timeToIdle: number): boolean {
   const [active, setActive] = useState(true)
   useEffect(() => {
     const activityDetector = createActivityDetector({
-      timeToIdle: timeToIdle
+      timeToIdle
     })
     activityDetector.on('idle', () => {
       setActive(false)

src/hooks/useIsUserActive.ts

@@ -1,22 +1,17 @@
 {
+  "extends": "@codingame/tsconfig",
   "compilerOptions": {
     "outDir": "dist/",
     "declaration": true,
     "skipLibCheck": true,
-    "allowSyntheticDefaultImports": true,
-    "strict": true,
     "baseUrl": "./app",
-    "esModuleInterop": true,
-    "forceConsistentCasingInFileNames": true,
-    "isolatedModules": true,
     "jsx": "react",
     "lib": [
       "dom",
       "dom.iterable",
       "esnext"
     ],
     "module": "esnext",
-    "moduleResolution": "node",
     "paths": {
       "app/*": [
         "*"