Correctly Group Drag-and-drop for Undo

thecoolwinter · thecoolwinter · commit 94ae22b1e042 · 2025-06-18T10:43:56.000-05:00
diff --git a/Sources/CodeEditTextView/TextView/TextView+Drag.swift b/Sources/CodeEditTextView/TextView/TextView+Drag.swift
@@ -255,10 +255,10 @@ extension TextView: NSDraggingSource {
             insertText("") // Replace the selected ranges with nothing
         }
 
-        undoManager?.endUndoGrouping()
-
         replaceCharacters(in: [NSRange(location: insertionOffset, length: 0)], with: insertionString)
 
+        undoManager?.endUndoGrouping()
+
         selectionManager.setSelectedRange(
             NSRange(location: insertionOffset, length: NSString(string: insertionString).length)
         )

Original file line number	Diff line number	Diff line change
`@@ -255,10 +255,10 @@ extension TextView: NSDraggingSource {`
`255`	`255`	`insertText("") // Replace the selected ranges with nothing`
`256`	`256`	`}`
`257`	`257`
`258`		`- undoManager?.endUndoGrouping()`
`259`		`-`
`260`	`258`	`replaceCharacters(in: [NSRange(location: insertionOffset, length: 0)], with: insertionString)`
`261`	`259`
	`260`	`+ undoManager?.endUndoGrouping()`
	`261`	`+`
`262`	`262`	`selectionManager.setSelectedRange(`
`263`	`263`	`NSRange(location: insertionOffset, length: NSString(string: insertionString).length)`
`264`	`264`	`)`