Addressing PR feedback. Updated changelog.

Author: david-lively

CHANGES.md

@@ -2,6 +2,10 @@
 
 ### ? - ?
 
+##### Additions :tada:
+
+- `ACesiumCartographicPolygon`s created via the Cesium editor panel are sized and transformed to be visible in the active editor viewport.
+
 ##### Fixes :wrench:
 
 - Fixed an access violation that could occur if `ACesium3DTileset::RefreshTileset` was invoked in a callback for asynchronous actions.

Source/CesiumEditor/Private/CesiumEditor.cpp

@@ -748,12 +748,12 @@ AActor* FCesiumEditorModule::SpawnBlankTileset() {
 }
 
 AActor* FCesiumEditorModule::SpawnCartographicPolygon() {
-  ACesiumCartographicPolygon* actor = static_cast<ACesiumCartographicPolygon*>(
+  ACesiumCartographicPolygon* pActor = static_cast<ACesiumCartographicPolygon*>(
       SpawnActorWithClass(ACesiumCartographicPolygon::StaticClass()));
-  if (actor) {
-    actor->ResetSplineAndCenterInEditorViewport();
+  if (pActor) {
+    pActor->ResetSplineAndCenterInEditorViewport();
   }
-  return actor;
+  return pActor;
 }
 
 UClass* FCesiumEditorModule::GetDynamicPawnBlueprintClass() {

Source/CesiumRuntime/Private/CesiumCartographicPolygon.cpp

@@ -4,7 +4,9 @@
 #include "CesiumActors.h"
 #include "Components/SceneComponent.h"
 #include "StaticMeshResources.h"
+#if WITH_EDITOR
 #include "Subsystems/UnrealEditorSubsystem.h"
+#endif
 #include <glm/glm.hpp>
 
 using namespace CesiumGeospatial;
@@ -14,20 +16,20 @@ bool ACesiumCartographicPolygon::ResetSplineAndCenterInEditorViewport() {
   if (!GEditor)
     return false;
 
-  UUnrealEditorSubsystem* editorSubsystem =
+  UUnrealEditorSubsystem* pEditorSubsystem =
       GEditor->GetEditorSubsystem<UUnrealEditorSubsystem>();
-  if (!editorSubsystem)
+  if (!pEditorSubsystem)
     return false;
 
   FVector viewPosition{};
   FRotator viewRotation{};
 
-  editorSubsystem->GetLevelViewportCameraInfo(viewPosition, viewRotation);
-  FVector viewDirection = viewRotation.Vector();
+  pEditorSubsystem->GetLevelViewportCameraInfo(viewPosition, viewRotation);
+  const FVector viewDirection = viewRotation.Vector();
 
   // Check if the ray and plane are parallel first to avoid division by zero
   if (FMath::Abs(FVector::DotProduct(viewDirection, FVector::UpVector)) <
-      DBL_EPSILON) {
+      KINDA_SMALL_NUMBER) {
     // Ray is parallel to the plane, no single intersection point.
     return false;
   }
@@ -38,7 +40,7 @@ bool ACesiumCartographicPolygon::ResetSplineAndCenterInEditorViewport() {
       viewDirection,
       groundPlane);
 
-  if (distance <= DBL_EPSILON) {
+  if (distance < KINDA_SMALL_NUMBER) {
     // no intersection found in front of the camera.
     return false;
   }
@@ -56,10 +58,9 @@ bool ACesiumCartographicPolygon::ResetSplineAndCenterInEditorViewport() {
 
   this->MakeLinear();
   this->SetActorLocation(spawnPosition);
+#endif
 
   return true;
-
-#endif
 }
 
 ACesiumCartographicPolygon::ACesiumCartographicPolygon() : AActor() {
@@ -78,12 +79,6 @@ ACesiumCartographicPolygon::ACesiumCartographicPolygon() : AActor() {
   };
 
   this->Polygon->SetSplinePoints(points, ESplineCoordinateSpace::Local);
-
-#if WITH_EDITOR
-  if (GEditor)
-    GEditor->RedrawAllViewports(true);
-#endif
-
   this->MakeLinear();
 #if WITH_EDITOR
   this->SetIsSpatiallyLoaded(false);

Source/CesiumRuntime/Public/CesiumCartographicPolygon.h

@@ -83,9 +83,9 @@ class CESIUMRUNTIME_API ACesiumCartographicPolygon : public AActor {
 
   /**
    * Set the spline points to a square centered where the editor camera view ray
-   * intersects the ground and sized to fit within thee viewport.
-   * @returns boolean indicating whether the spline points and transform were
-   * successfully recomputed.
+   * intersects the ground and sized to fit within the viewport.
+   * @returns Whether the spline points and transform were successfully
+   * recomputed.
    */
   bool ResetSplineAndCenterInEditorViewport();