Skip to content

Multiple hash definitions results in invalid SQL #846

@afn

Description

@afn

Steps to reproduce

When there are multiple hash conditions, the generated SQL is invalid. See failing spec here: afn@bc1478d

The generated SQL is:

SELECT "legacy_mentions".* FROM "legacy_mentions" WHERE "legacy_mentions"."id" IN (SELECT "legacy_mentions"."id" FROM "legacy_mentions" LEFT OUTER JOIN "users" ON "users"."id" = "legacy_mentions"."user_id" LEFT OUTER JOIN "articles" ON "articles"."id" = "legacy_mentions"."article_id" LEFT OUTER JOIN "users" "users_articles" ON "users_articles"."id" = "articles"."user_id" WHERE (("users_articles"."company" = 1) OR ("users"."company_id" = 1)))

whereas it should be:

SELECT "legacy_mentions".* FROM "legacy_mentions" WHERE "legacy_mentions"."id" IN (SELECT "legacy_mentions"."id" FROM "legacy_mentions" LEFT OUTER JOIN "users" ON "users"."id" = "legacy_mentions"."user_id" LEFT OUTER JOIN "articles" ON "articles"."id" = "legacy_mentions"."article_id" LEFT OUTER JOIN "users" "users_articles" ON "users_articles"."id" = "articles"."user_id" WHERE (("users_articles"."company_id" = 1) OR ("users"."company_id" = 1)))

(Note company_id versus company.)

Expected behavior

Spec should pass

Actual behavior

Spec fails with an error

System configuration

Rails version: 6.1.0

Ruby version: 3.0.1

CanCanCan version 3.5.0 and current develop branch

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions