Issue with cutting a cylinder from a torus (revolved circle)

[bedilu]

To Reproduce

import cadquery as cq
import pyvista as pv

#Initialize the assembly
model = cq.Assembly()

#Define the major and minor radii for the torus
R = 50.0
r = 20.0

#Create a circle in the XY plane with the minor radius r
torus_profile = cq.Workplane("XY").circle(r)

#Revolve the circle around Y-axis to generate the torus
torus = torus_profile.revolve(angleDegrees=360, axisStart=[R, 0, 0], axisEnd=[R, 1, 0])

#Define the radius and height of the cylinder
#cylinder_radius = r/5    # It works for this radius!
cylinder_radius = r/4

cylinder_height = 4*R  # Ensure the height is enough to pierce through the torus

#Create the cylinder in the YZ plane, centered at the origin
cylinder = cq.Workplane("YZ").circle(cylinder_radius).extrude(cylinder_height)

#Move the cylinder to the center of the torus
cylinder = cylinder.translate((-R, 0, 0))

#Cut the cylinder from the torus
#pierced_torus = torus.add(cylinder)
pierced_torus = torus.cut(cylinder)

model.add(pierced_torus)

#Export/Show the result
model.toCompound().exportStl('cut_torus.stl')   # .stl / .step / .glb are supported
#Export the assembly to a STEP file
cq.exporters.export(model.toCompound(), 'cut_torus.step')

#View model
pv_mesh = pv.read('cut_torus.stl')
pl = pv.Plotter()
pl.add_mesh(pv_mesh)
pl.show()

Backtrace

Environment

OS:

Was CadQuery installed using Conda?:

Output of conda list from your active Conda environment:

Using:

Working on Win10; cadquery (2.5.2) is installed using pip; plus VSCode

[jmwright]

I cannot get the exact same result from the STL or the PV mesh, but I do get non-manifold behavior that does not seem to be fixed by cleaning the object before hand or changing the tolerances. Maybe an OCC kernel issue related to #1796 ?

Also, you do not have to use the assembly object here. You can export the shape using cq.exporters.export or can call exportStl directly.

import cadquery as cq
import pyvista as pv

#Define the major and minor radii for the torus
R = 50.0
r = 20.0

#Create a circle in the XY plane with the minor radius r
torus_profile = cq.Workplane("XY").circle(r)

#Revolve the circle around Y-axis to generate the torus
torus = torus_profile.revolve(angleDegrees=360, axisStart=[R, 0, 0], axisEnd=[R, 1, 0])

#Define the radius and height of the cylinder
#cylinder_radius = r/5 # It works for this radius!
cylinder_radius = r/4

cylinder_height = 4*R # Ensure the height is enough to pierce through the torus

#Create the cylinder in the YZ plane, centered at the origin
cylinder = cq.Workplane("YZ").circle(cylinder_radius).extrude(cylinder_height)

#Move the cylinder to the center of the torus
cylinder = cylinder.translate((-R, 0, 0))

#Cut the cylinder from the torus
pierced_torus = torus.cut(cylinder)

#Export/Show the result
pierced_torus.clean().val().exportStl('cut_torus.stl', tolerance=0.01, angularTolerance=0.05)
cq.exporters.export(pierced_torus, 'cut_torus.step')

#View model
pv_mesh = pv.read('cut_torus.stl')
pl = pv.Plotter()
pl.add_mesh(pv_mesh)
pl.show()

[bedilu]

@jmwright

Using higher value for cylinder_radius produces similar results; try:
cylinder_radius = r/2

[lorenzncode]

cut with clean=False resolved it for me. I tested with cylinder_radius = r/2.

pierced_torus = torus.cut(cylinder, clean=False)

[bedilu]

@lorenzncode
Yes, setting clean=False is a good workaround. Thanks!