Skip to content

Commit d2ce82d

Browse files
committed
squash! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Code Quality: Address shadowing
Removed redundant converters
1 parent 612dc1b commit d2ce82d

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

implementation/configuration/src/configuration_impl.cpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2303,24 +2303,22 @@ void configuration_impl::load_eventgroup(
23032303
}
23042304
} else if (its_key == "threshold") {
23052305
int its_threshold(0);
2306-
std::stringstream its_converter_inner;
2307-
its_converter_inner << std::dec << its_value;
2308-
its_converter_inner >> std::dec >> its_threshold;
2306+
its_converter << std::dec << its_value;
2307+
its_converter >> std::dec >> its_threshold;
23092308
its_eventgroup->threshold_ =
23102309
(its_threshold > std::numeric_limits<std::uint8_t>::max()) ?
23112310
std::numeric_limits<std::uint8_t>::max() :
23122311
static_cast<uint8_t>(its_threshold);
23132312
} else if (its_key == "events") {
23142313
for (auto k = j->second.begin(); k != j->second.end(); ++k) {
2315-
std::stringstream its_converter_inner;
23162314
std::string its_value_inner(k->second.data());
23172315
event_t its_event_id(0);
23182316
if (its_value_inner.size() > 1 && its_value_inner[0] == '0' && its_value_inner[1] == 'x') {
2319-
its_converter_inner << std::hex << its_value_inner;
2317+
its_converter << std::hex << its_value_inner;
23202318
} else {
2321-
its_converter_inner << std::dec << its_value_inner;
2319+
its_converter << std::dec << its_value_inner;
23222320
}
2323-
its_converter_inner >> its_event_id;
2321+
its_converter >> its_event_id;
23242322
if (0 < its_event_id) {
23252323
std::shared_ptr<event> its_event(nullptr);
23262324
auto find_event = _service->events_.find(its_event_id);

0 commit comments

Comments
 (0)