Fix Delete AWS deployment issue

Author: kbeaugrand

src/IoTHub.Portal.Infrastructure/Services/AWS/AwsConfigService.cs

@@ -219,11 +219,20 @@ public Task<Configuration> GetConfigItem(string id)
 
         public async Task DeleteConfiguration(string modelId)
         {
-            var modules = await GetConfigModuleList(modelId);
-
-            //Deprecate Deployment Thing type
+            // Deprecate Deployment Thing type
             await DeprecateDeploymentThingType(modelId);
 
+            IEnumerable<IoTEdgeModule> modules = Array.Empty<IoTEdgeModule>();
+
+            try
+            {
+                modules = await GetConfigModuleList(modelId);
+            }
+            catch (InternalServerErrorException e)
+            {
+                this.logger.LogError($"Failed to get model modules when deleting. Some resources might persist in AWS for model {modelId}.");
+            }
+
             foreach (var module in modules.Where(c => string.IsNullOrEmpty(c.Id)))
             {
                 try
@@ -261,9 +270,7 @@ public async Task DeleteConfiguration(string modelId)
             catch (AmazonGreengrassV2Exception e)
             {
                 throw new InternalServerErrorException("The deletion of the deployment failed due to an error in the Amazon IoT API.", e);
-
             }
-
         }
 
         private async Task DeprecateDeploymentThingType(string modelId)
@@ -387,7 +394,6 @@ public async Task<List<IoTEdgeModule>> GetConfigModuleList(string modelId)
             catch (Amazon.GreengrassV2.Model.ResourceNotFoundException)
             {
                 throw new InternalServerErrorException("Unable to find the deployment due to an error in the Amazon IoT API. ");
-
             }
         }