Skip to content

Conversation

@sbidari
Copy link
Collaborator

@sbidari sbidari commented Sep 17, 2025

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.65%. Comparing base (df077cd) to head (2307d6a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   14.65%   14.65%           
=======================================
  Files           6        6           
  Lines         423      423           
=======================================
  Hits           62       62           
  Misses        361      361           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should qualify namespaces for the functions used from epipredict (epipredict::fn()), rather than having a library call within the function call.

I failed to notice the library(epipredict) invocation when I reviewed #11. I should have flagged it then; my apologies.

@sbidari
Copy link
Collaborator Author

sbidari commented Sep 17, 2025

Should qualify namespaces for the functions used from epipredict (epipredict::fn()), rather than having a library call within the function call.

I am using namespace qualifiers but the function epipredict::flusight_hub_formatter is referencing an object (state_census) that is not available unless you load the library separately. This is the line of the code with the issue

epipredict::flusight_hub_formatter(

@sbidari
Copy link
Collaborator Author

sbidari commented Sep 17, 2025

@dylanhmorris
Copy link
Contributor

dylanhmorris commented Sep 17, 2025

We should file an issue in epipredict; R functions should not expect you to have loaded the package to execute (the solution here will be to namespace qualify state_census

Since this is likely to be a simple fix, I think our best option option here is probably just to fork epipredict, fix it, and make a PR. We can depend on our own fork while we wait for the fix to land.

@dylanhmorris
Copy link
Contributor

@dylanhmorris
Copy link
Contributor

Opened cmu-delphi/epipredict#470

@dylanhmorris
Copy link
Contributor

@sbidari my PR has now landed on dev, and it looks like it will be added to main shortly: cmu-delphi/epipredict#471

Copy link
Contributor

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbidari!

@dylanhmorris dylanhmorris merged commit 0708209 into main Sep 19, 2025
6 checks passed
@sbidari sbidari deleted the sb-generate-baseline-fix branch September 29, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants