-
Notifications
You must be signed in to change notification settings - Fork 0
update generate_hub_baseline.R #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 14.65% 14.65%
=======================================
Files 6 6
Lines 423 423
=======================================
Hits 62 62
Misses 361 361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should qualify namespaces for the functions used from epipredict (epipredict::fn()), rather than having a library call within the function call.
I failed to notice the library(epipredict) invocation when I reviewed #11. I should have flagged it then; my apologies.
I am using namespace qualifiers but the function hubhelpr/R/generate_hub_baselines.R Line 161 in 756f954
|
|
We should file an issue in Since this is likely to be a simple fix, I think our best option option here is probably just to fork |
|
Working on this here: https://github.com/dylanhmorris/epipredict/tree/dylanhmorris-fix-flusight-hub-formatter |
|
Opened cmu-delphi/epipredict#470 |
|
@sbidari my PR has now landed on |
dylanhmorris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sbidari!
library(epipredict)insidegenerate_hub_baseline.R(https://github.com/CDCgov/rsv-forecast-hub/actions/runs/17810156474/job/50631665229)devtools::document()