DRYify Map And Forecast Functions (#71)

* attempt to dryify code

* update function description

* attempt to try review comments

* make return statements explicit; change param order; update params; add line breaks

* run devtools document

* add dhm suggested edits

* typos edit

* run devtools document

Author: O957

.pre-commit-config.yaml

@@ -48,7 +48,7 @@ repos:
         args: ['--baseline', '.secrets.baseline']
         exclude: package.lock.json
 -   repo: https://github.com/crate-ci/typos
-    rev: v1
+    rev: v1.39.1
     hooks:
     -   id: typos
         args: ["--force-exclude"]

DESCRIPTION

@@ -9,7 +9,7 @@ Description: This package provides functions to help with the maintenance of CDC
 License: Apache License (>= 2)
 Encoding: UTF-8
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.3.2
+RoxygenNote: 7.3.3
 Imports:
     checkmate,
     cli,

NAMESPACE

@@ -6,11 +6,13 @@ export(excluded_locations)
 export(generate_hub_baseline)
 export(generate_hub_ensemble)
 export(generate_oracle_output)
-export(get_forecast_data)
 export(get_hub_name)
-export(get_map_data)
 export(included_locations)
+export(summarize_ref_date_forecasts)
 export(update_authorized_users)
 export(update_hub_target_data)
+export(write_ref_date_summary)
+export(write_ref_date_summary_all)
+export(write_ref_date_summary_ens)
 importFrom(rlang,":=")
 importFrom(rlang,.data)

R/check_authorized_users.R

@@ -84,5 +84,5 @@ check_authorized_users <- function(
   cli::cli_inform(
     "Success: Changes authorized for user '{gh_actor}'."
   )
-  invisible()
+  return(invisible())
 }

R/check_changes_for_autoapproval.R

@@ -74,5 +74,5 @@ check_changes_for_autoapproval <- function(
     )
   }
 
-  invisible()
+  return(invisible())
 }

R/generate_hub_baselines.R

@@ -246,5 +246,5 @@ generate_hub_baseline <- function(
     )
   )
 
-  invisible()
+  return(invisible())
 }

R/generate_hub_ensemble.R

@@ -165,5 +165,5 @@ generate_hub_ensemble <- function(
     median_ensemble_outputs,
     fs::path(output_dirpath, output_filename, ext = "csv")
   )
-  invisible()
+  return(invisible())
 }

R/generate_oracle_output.R

@@ -108,5 +108,5 @@ generate_oracle_output <- function(hub_path) {
 
   output_file <- fs::path(output_dirpath, "oracle-output", ext = "parquet")
   forecasttools::write_tabular_file(oracle_data, output_file)
-  invisible()
+  return(invisible())
 }