solve issue #506

facontidavide · facontidavide · commit 7bb5e3887256 · 2023-02-17T11:15:40.000+01:00
diff --git a/include/behaviortree_cpp/utils/convert_impl.hpp b/include/behaviortree_cpp/utils/convert_impl.hpp
@@ -142,7 +142,11 @@ void convertNumber( const SRC& source, DST& target )
     // casting to/from floating points might cause truncation.
     else if constexpr( std::is_floating_point<SRC>::value || std::is_floating_point<DST>::value )
     {
-        checkTruncation<SRC,DST>(source);
+        bool both_float = std::is_floating_point<SRC>::value && std::is_floating_point<DST>::value;
+        // to avoid being too pedantic, let's accept casting between double and float
+        if(!both_float){
+            checkTruncation<SRC,DST>(source);
+        }
         target = static_cast<DST>(source);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,11 @@ void convertNumber( const SRC& source, DST& target )`
`142`	`142`	`// casting to/from floating points might cause truncation.`
`143`	`143`	`else if constexpr( std::is_floating_point<SRC>::value \|\| std::is_floating_point<DST>::value )`
`144`	`144`	`{`
`145`		`- checkTruncation<SRC,DST>(source);`
	`145`	`+ bool both_float = std::is_floating_point<SRC>::value && std::is_floating_point<DST>::value;`
	`146`	`+ // to avoid being too pedantic, let's accept casting between double and float`
	`147`	`+ if(!both_float){`
	`148`	`+ checkTruncation<SRC,DST>(source);`
	`149`	`+ }`
`146`	`150`	`target = static_cast<DST>(source);`
`147`	`151`	`}`
`148`	`152`	`}`