Skip to content

Prompt to discard conversation incompatible with keyword apps #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thestumonkey opened this issue May 2, 2025 · 0 comments
Open

Prompt to discard conversation incompatible with keyword apps #2284

thestumonkey opened this issue May 2, 2025 · 0 comments

Comments

@thestumonkey
Copy link
Contributor

Describe the bug
Some apps that should trigger do not because they get discarded before they can be processed

To Reproduce
Steps to reproduce the behavior:

  1. Create an app with a prompt that involves listening for a keyword or phases. Example: Brain dump (01JRTA6VPJPC8KBAE622JZE1BF)
  2. Mention the keyphrase and then a few things to remember. Keep it short.

Current behavior
should_discard_conversation is running this prompt before it checks any of the plugins: \

You will be given a conversation transcript, and your task is to determine if the conversation is worth storing as a memory or not.
    It is not worth storing if there are no interesting topics, facts, or information, in that case, output discard = True
```.
Consequently it has no knowledge that I've used a trigger keyword, the conversation gets discarded before any app processing can occur.
The discard prompt is very vague and it's unclear what would be "interesting topics facts or information".  Does it use the context from the rest of my memories on what *I* find interesting?  Or is this an llm without context?

**Expected behavior**
1:  Any installed apps prompts should factor into the decision on if to discard the conversation or not.  
2: Suggest modifying this prompt to add the descriptor "Applicable".  Then potentially use a pre-processor on all the apps to determine what is "applicable".  This would avoid having to iterate through all the apps to see if the conversation would trigger, as if there are many apps, this prompt could get large.  Alternatively the apps model could contain a shorter prompt "do not discard if: "
3: The discard prompt is very vague and it's unclear what would be "interesting topics facts or information".  It would be interesting to let the user modify this through developer tools.  

**Screenshots**
If applicable, add screenshots to help explain your problem.

**user ID (can we access the user info to validate the bug?):**
Can be found in settings => profile

**Smartphone + device (please complete the following information):**
 - Device: iPhone16
 - OS: 18.4.1
 - Browser [e.g. stock browser, safari]
 - App Version 1.0.59+273
 -  Device version 2.0.10

**Additional context**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant