Skip to content

Use spring-cloud-azure-supported-spring.json from SHA running in pipeline #45602

Open
@alzimmermsft

Description

@alzimmermsft

While reviewing a version update PR for Cosmos I found that the Spring compatibility tests were failing (due to valid reasons, unrelated to the Cosmos version change). Looking at the Cosmos PR, I noticed the version of Spring being validated in the java - spring - compatibility-tests pipeline was 3.5.0, in the PR that added 3.5.0 as a supported version it didn't run 3.5.0.

After doing further digging this was due to how the pipeline generated jobs. It is hard coded to pull the spring-cloud-azure-supported-spring.json configuration file from main. What it should be doing instead is checking out that configuration file in the pipeline and using the version of the file from the SHA being validated in CI. This would have prevented this case, where the PR adding support didn't validate that 3.5.0 (or any future addition) actually was supported fully.

The CI logic needs to be updated to remove these hard coded references to the main version of spring-cloud-azure-supported-spring.json and use the local file checked out in CI:

https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/spring/scripts/compatibility_get_spring_cloud_version.py#L26
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/spring/scripts/compatibility_update_supported_version_matrix_json.py#L78
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/spring/scripts/monitor_update_monitor_matrix_json.py#L52

Metadata

Metadata

Assignees

Labels

ClientThis issue points to a problem in the data-plane of the library.EngSysThis issue is impacting the engineering system.azure-springAll azure-spring related issuesbugThis issue requires a change to an existing behavior in the product in order to be resolved.needs-team-attentionWorkflow: This issue needs attention from Azure service team or SDK team

Type

No type

Projects

Status

Todo

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions