Merge pull request #217 from slorello89/bugfix/swallowed-seralization-errors

removing empty catch.

Author: stanleysmall-microsoft

src/RedisSessionStateProvider/RedisConnectionWrapper.cs

@@ -334,16 +334,10 @@ private bool TryUpdateAndReleaseLockPrepare(object lockId, ISessionStateItemColl
                 List<object> list = new List<object>();
                 int noOfItemsRemoved = 0;
                 int noOfItemsUpdated = 0;
-                try
-                {
-                    byte[] serializedSessionStateItemCollection = SerializeSessionStateItemCollection(data);
-                    list.Add("SessionState");
-                    list.Add(serializedSessionStateItemCollection);
-                    noOfItemsUpdated = 1;
-                }
-                catch
-                {
-                }
+                byte[] serializedSessionStateItemCollection = SerializeSessionStateItemCollection(data);
+                list.Add("SessionState");
+                list.Add(serializedSessionStateItemCollection);
+                noOfItemsUpdated = 1;
 
                 keyArgs = new string[] { Keys.LockKey, Keys.DataKey, Keys.InternalKey };
                 valueArgs = new object[list.Count + 8]; // this +8 is for first wight values in ARGV that we will add now

test/RedisSessionStateProviderUnitTest/RedisConnectionWrapperTests.cs

@@ -8,6 +8,7 @@
 using System.Configuration;
 using System.IO;
 using System.Threading;
+using System.Web;
 using System.Web.SessionState;
 using Xunit;
 
@@ -246,6 +247,22 @@ public void TryRemoveIfLockIdMatch_Valid()
             A.CallTo(() => redisConn.redisConnection.Eval(A<string>.Ignored, A<string[]>.That.Matches(s => s.Length == 3),
                  A<object[]>.That.Matches(o => o.Length == 1))).MustHaveHappened();
         }
+        
+        [Fact]
+        public void TrySetObjectNotMarkedSerializable()
+        {
+            string id = "session_id";
+            int sessionTimeout = 900;
+            object lockId = DateTime.Now.Ticks;
+            SessionStateItemCollection data = new SessionStateItemCollection();
+            data["Key"] = new {Name = "Hal"}; // try to add anon type, this will throw a serialization error when you try to commit it as the type is not marked as serializable.
+
+            RedisConnectionWrapper.sharedConnection = A.Fake<RedisSharedConnection>();
+            RedisConnectionWrapper redisConn = new RedisConnectionWrapper(Utility.GetDefaultConfigUtility(), id);
+            redisConn.redisConnection = A.Fake<IRedisClientConnection>();
+            var exception = Assert.Throws<HttpException>(() =>redisConn.TryUpdateAndReleaseLock(lockId, data, sessionTimeout));
+            Assert.Contains("Unable to serialize the session state.", exception.Message);
+        }
 
         [Fact]
         public void TryUpdateIfLockIdMatchPrepare_NoUpdateNoDelete()