Skip to content

Commit 9cedc5e

Browse files
committed
kbuild: use proper prefix for tarballs to fix rpm-pkg build error
Since commit f8d94c4 ("kbuild: do not create intermediate *.tar for source tarballs"), 'make rpm-pkg' fails because the prefix of the source tarball is 'linux.tar/' instead of 'linux/'. $(basename $@) strips only '.gz' from the filename linux.tar.gz. You need to strip two suffixes from compressed tarballs and one suffix from uncompressed tarballs (for example 'perf-6.3.0.tar' generated by 'make perf-tar-src-pkg'). One tricky fix might be --prefix=$(firstword $(subst .tar, ,$@))/ but I think it is better to hard-code the prefix. Fixes: f8d94c4 ("kbuild: do not create intermediate *.tar for source tarballs") Reported-by: Jiwei Sun <[email protected]> Signed-off-by: Masahiro Yamada <[email protected]> Reviewed-by: Nicolas Schier <[email protected]>
1 parent 8b82422 commit 9cedc5e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

scripts/Makefile.package

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,15 @@ git-config-tar.zst = -c tar.tar.zst.command="$(ZSTD)"
4949

5050
quiet_cmd_archive = ARCHIVE $@
5151
cmd_archive = git -C $(srctree) $(git-config-tar$(suffix $@)) archive \
52-
--output=$$(realpath $@) --prefix=$(basename $@)/ $(archive-args)
52+
--output=$$(realpath $@) $(archive-args)
5353

5454
# Linux source tarball
5555
# ---------------------------------------------------------------------------
5656

5757
linux-tarballs := $(addprefix linux, .tar.gz)
5858

5959
targets += $(linux-tarballs)
60-
$(linux-tarballs): archive-args = $$(cat $<)
60+
$(linux-tarballs): archive-args = --prefix=linux/ $$(cat $<)
6161
$(linux-tarballs): .tmp_HEAD FORCE
6262
$(call if_changed,archive)
6363

@@ -189,7 +189,7 @@ perf-archive-args = --add-file=$$(realpath $(word 2, $^)) \
189189
perf-tarballs := $(addprefix perf-$(KERNELVERSION), .tar .tar.gz .tar.bz2 .tar.xz .tar.zst)
190190

191191
targets += $(perf-tarballs)
192-
$(perf-tarballs): archive-args = $(perf-archive-args)
192+
$(perf-tarballs): archive-args = --prefix=perf-$(KERNELVERSION)/ $(perf-archive-args)
193193
$(perf-tarballs): tools/perf/MANIFEST .tmp_perf/HEAD .tmp_perf/PERF-VERSION-FILE FORCE
194194
$(call if_changed,archive)
195195

0 commit comments

Comments
 (0)