Skip to content

Provide a Docker image #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mms-gianni opened this issue Nov 15, 2024 · 6 comments · May be fixed by #439
Open

Provide a Docker image #434

mms-gianni opened this issue Nov 15, 2024 · 6 comments · May be fixed by #439
Labels
feature Feature request or suggestion

Comments

@mms-gianni
Copy link

mms-gianni commented Nov 15, 2024 •
edited
Loading

Feature

Jasoncrack looks amazing and I appreciate providing it opensource. Thank you.

To enhance accessibility, a prebuilt image of Jasoncrack hosted on GitHub Container Registry would be beneficial.

I can contribute a build action.

Alternative solutions or implementations

No response

Other context

No response
@mms-gianni mms-gianni added the feature Feature request or suggestion label Nov 15, 2024
@albert849
Copy link

🔥

@mms-gianni
Copy link
Author

Created a PR for this: #439

@mms-gianni
Copy link
Author

Oh, accidently closed this issue

@mms-gianni mms-gianni reopened this Nov 22, 2024
@dvisigalli
Copy link

An "official" Docker Image would be much appreciated!!!
I'm currently trying a self built one that i found on Docker Hub and i found out that, apparently, there is no way to expose the service from a subpath.
Stripping prefix does not solve completely the problem, because on client side the browser tries to load js and css resources from wrong urls (the stripped ones of course).
So please would you consider a way to make the application "self aware" to be serving from a subpath, maybe using and environmental variable just like spring applications do for example.
Thanks!!!

@AykutSarac AykutSarac linked a pull request Dec 18, 2024 that will close this issue
Github Action to build and push docker images #439
Open
@avmesquita
Copy link

avmesquita commented Jan 24, 2025 •
edited
Loading

docker compose build (OK)
docker compose up (Error)

Image

docker build . (Error)

Image

vishwamartur added a commit to vishwamartur/jsoncrack.com that referenced this issue Jan 29, 2025
@vishwamartur
Add Docker image to GitHub Container Registry
96aa35b 
Related to AykutSarac#434

Add a prebuilt Docker image of JSON Crack to GitHub Container Registry.

* **README.md**
  - Add instructions for using the prebuilt Docker image.
  - Mention the GitHub Container Registry as the source.

* **.github/workflows/docker-image.yml**
  - Create a new GitHub Actions workflow file.
  - Add steps to build Docker image.
  - Add steps to push Docker image to GitHub Container Registry.
@vishwamartur vishwamartur mentioned this issue Jan 29, 2025
Open
@hahwul
Copy link

hahwul commented Feb 3, 2025 •
edited
Loading

@avmesquita
I'm also building a Docker image and encountering the same issue. It was fixed in corepack v0.31.0, but the base image for jsoncrack.com, node:lts-alpine, hasn't been updated yet. We'll have to wait, but if a build is necessary, I think we can solve it by modifying parts of the Dockerfile.

docker run -it node:lts-alpine sh
/ # corepack
━━━ Corepack - 0.30.0 ━━━━━━━

Temporary code for hotfix

RUN npm i -g corepack@latest && corepack enable pnpm && pnpm install --frozen-lockfile

Ref: nodejs/corepack#614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Feature request or suggestion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Github Action to build and push docker images mms-gianni/jsoncrack.com
5 participants
@avmesquita @mms-gianni @hahwul @dvisigalli @albert849