fix: remove duplicate call to send device updates to the hub (#1973)

* chore: Fixed duplicate call to send device updates to the hub

* chore: Fixed duplicate call to send device updates to the hub

* chore: Fixed duplicate call to send device updates to the hub

---------

Co-authored-by: Яснецов Петр Андреевич <[email protected]>

Author: Petrdontone

src/device-managers/IOSDeviceManager.ts

@@ -366,14 +366,6 @@ export default class IOSDeviceManager implements IDeviceManager {
   public async getSimulators(): Promise<Array<IDevice>> {
     const simulators = await this.fetchLocalSimulators();
     simulators.sort((a, b) => (a.state > b.state ? 1 : -1));
-
-    // should not be here, but we need to update the hub with simulators
-    if (this.pluginArgs.hub !== undefined) {
-      log.info('Updating Hub with Simulators');
-      const nodeDevices = new NodeDevices(this.pluginArgs.hub);
-      await nodeDevices.postDevicesToHub(simulators, 'add');
-    }
-
     return simulators;
   }
 

src/plugin.ts

@@ -10,7 +10,6 @@ import { createRouter } from './app';
 import commands from './commands/index';
 import {
   getDevice,
-  setSimulatorState,
   unblockDevice,
   unblockDeviceMatchingFilter,
   updatedAllocatedDevice,
@@ -23,10 +22,7 @@ import { DeviceFarmManager } from './device-managers';
 import ChromeDriverManager from './device-managers/ChromeDriverManager';
 import {
   allocateDeviceForSession,
-  deviceType,
   initializeStorage,
-  isIOS,
-  refreshSimulatorState,
   removeStaleDevices,
   setupCronCheckStaleDevices,
   setupCronCleanPendingSessions,
@@ -276,6 +272,7 @@ class DevicePlugin extends BasePlugin {
         DevicePlugin.NODE_ID,
       );
       await NodeHealthMonitor.getInstance().start(NODE_HEALTH_MONITOR_INTERVAL);
+      await updateDeviceList(pluginArgs.bindHostOrIp);
       log.info(`📣📣📣 I'm a hub and I'm listening on ${pluginArgs.bindHostOrIp}:${cliArgs.port}`);
     }
 
@@ -307,12 +304,6 @@ class DevicePlugin extends BasePlugin {
     } else {
       log.info('📣📣📣 Cloud runner sessions dont require constant device checks');
     }
-
-    const devicesUpdates = await updateDeviceList(pluginArgs.bindHostOrIp, hubArgument);
-    if (isIOS(pluginArgs) && deviceType(pluginArgs, 'simulated')) {
-      await setSimulatorState(devicesUpdates);
-      await refreshSimulatorState(pluginArgs, cliArgs.port);
-    }
     log.info(
       `📣📣📣 Device Farm Plugin will be served at 🔗 http://${pluginArgs.bindHostOrIp}:${cliArgs.port}/device-farm with id ${DevicePlugin.NODE_ID}`,
     );