Are you sure you support the new architecture? Looking at the source code, it doesn't seem like

[yangchongduo]

Are you sure you support the new architecture? Looking at the source code, it doesn't seem like

[Minishlink]

Hello, new architecture is supported in v11 release candidates with core features of CodePush (eg. installing updates) working. It's still in release candidate because some non essential things are not completely working. That's something I'd like to tackle in the coming weeks. Note that other CodePush alternatives may advertise as full support (no release candidate) but it's actually false (some of them directly copied our code without thinking and without giving credit 🫠).

If you're talking about TurboModule, this is a completely different topic and is not necessary to support the new architecture, thanks to bridgeless mode. That being said, we already migrated the codebase to Typescript so it would make sense to also have TurboModules in the future for type safety between native and JS. It's just not a priority for the moment because it would not add much value to users (there aren't many native calls made). With that in mind, I did a poc a while ago so if you are very interested in TurboModule (curious to know why), I could prioritize this.

[yangchongduo]

v11-rc version
Public class CodePush implementations ReactPackage {} or extends ReactPackage
React native latest version based on BaseReactPackage
···
package com.facebook.react
@deprecated(
message = "Use BaseReactPackage instead",
replaceWith = ReplaceWith(expression = "BaseReactPackage"))
public abstract class TurboReactPackage : BaseReactPackage() {}
···

To implement methods such as getModule and getReactModulus InfoProvider based on BaseReactPackage

[Minishlink]

Yep so that's a turbo module, not new arch support. I'll take a look to implement this without codegen (codegen should be the most "problematic" part)

[yangchongduo]

4. Rename CodePushDeploymentKey to CodePushReleaseChannelPublicId in your strings resources (located either at strings.xml or app/build.gradle).
5. In Android, didn't you see how to obtain it?

[yangchongduo]

"new CodePush(getResources().getString(R.string.CodePushDeploymentKey), getApplicationContext(), BuildConfig.DEBUG)"
This is the initial way, in the new architecture, how to obtain

[yangchongduo]

resValue 'string', "CodePushReleaseChannelPublicId", project.env.get("CODEPUSH_RELEASE_CHANNEL_PUBLIC_ID_ANDROID")

String releaseChannelPublicIdFromStrings = getCustomPropertyFromStringsIfExist("ReleaseChannelPublicId");
int resId = mContext.getResources().getIdentifier("CodePush" + propertyName, "string", packageName);
Has the key been assembled?

[Minishlink]

Hello, please take a look at the migration guide. The value stays the same, only the key (DeploymentKey => ReleaseChannelPublicId) changes.
"Deployment" was a poor choice in the original design of CodePush since it can be confused between the action of deploying (release deployment) and the different channels where you can deploy (release channels).

[yangchongduo]

React native code push has a getConstants method on Android, but not on iOS? Why?

[yangchongduo]

#import "JWT.h" no

[knro]

Any ETA on v11 release?

[Minishlink]

Hello @yangchongduo,

React native code push has a getConstants method on Android, but not on iOS? Why?

That's quite normal :) Not sure what you want here, maybe if you write in your native language I might translate it better? Thanks

[Minishlink]

Hello @knro

Any ETA on v11 release?

Maybe quite soon :) Well I'm not sure if I'll release the v11 without turbo module or not. Any way the next release candidate (this week) will be working 100% on new arch apps. The current release candidate works great for basic CodePush functionnality without big impact (download progress callback is not triggering for exemple), so you can use it today.

[yangchongduo]

#import "JWT.h" 为什么 你的项目里面没有 这个
react-native-code-push 是有的

[Minishlink]

The JWT library is used for code signing. Our module installs the JWT library through cocoapods (see podspec)

[knro]

Thank you. Another question, will this package work on a standalone code push server?