Fix Android loadJar (#10867)

* Fix Android loadJar

* Using another way

* Code formating

* Fix mod update

Author: DSFdsfWxp

android/src/mindustry/android/AndroidLauncher.java

@@ -73,28 +73,57 @@ public void shareFile(Fi file){
             @Override
             public ClassLoader loadJar(Fi jar, ClassLoader parent) throws Exception{
                 //Required to load jar files in Android 14: https://developer.android.com/about/versions/14/behavior-changes-14#safer-dynamic-code-loading
-                jar.file().setReadOnly();
-                return new DexClassLoader(jar.file().getPath(), getFilesDir().getPath(), null, parent){
-                    @Override
-                    protected Class<?> loadClass(String name, boolean resolve) throws ClassNotFoundException{
-                        //check for loaded state
-                        Class<?> loadedClass = findLoadedClass(name);
-                        if(loadedClass == null){
-                            try{
-                                //try to load own class first
-                                loadedClass = findClass(name);
-                            }catch(ClassNotFoundException | NoClassDefFoundError e){
-                                //use parent if not found
-                                return parent.loadClass(name);
+                try{
+                    jar.file().setReadOnly();
+                    return new DexClassLoader(jar.file().getPath(), getFilesDir().getPath(), null, parent){
+                        @Override
+                        protected Class<?> loadClass(String name, boolean resolve) throws ClassNotFoundException{
+                            //check for loaded state
+                            Class<?> loadedClass = findLoadedClass(name);
+                            if(loadedClass == null){
+                                try{
+                                    //try to load own class first
+                                    loadedClass = findClass(name);
+                                }catch(ClassNotFoundException | NoClassDefFoundError e){
+                                    //use parent if not found
+                                    return parent.loadClass(name);
+                                }
                             }
-                        }
 
-                        if(resolve){
-                            resolveClass(loadedClass);
+                            if(resolve){
+                                resolveClass(loadedClass);
+                            }
+                            return loadedClass;
                         }
-                        return loadedClass;
+                    };
+                }catch(SecurityException e){
+                    //`setReadOnly` to jar file in `/sdcard/Android/data/...` does not work on some Android 14 device
+                    //But in `/data/...` it works
+
+                    if(Build.VERSION.SDK_INT < VERSION_CODES.O_MR1){
+                        throw e;
+                    }
+
+                    Fi cacheDir = new Fi(getCacheDir()).child("mods");
+                    cacheDir.mkdirs();
+
+                    //long file name support
+                    Fi modCacheDir = cacheDir.child(jar.nameWithoutExtension());
+                    Fi modCache = modCacheDir.child(Long.toHexString(jar.lastModified()) + ".zip");
+
+                    if(modCacheDir.equals(jar.parent())){
+                        //should not reach here, just in case
+                        throw e;
                     }
-                };
+
+                    //Cache will be deleted when mod is removed
+                    if(!modCache.exists() || jar.length() != modCache.length()){
+                        modCacheDir.mkdirs();
+                        jar.copyTo(modCache);
+                    }
+                    modCache.file().setReadOnly();
+                    return loadJar(modCache, parent);
+                }
             }
 
             @Override

core/assets/contributors

@@ -182,3 +182,4 @@ MonoChronos
 RushieWashie
 ITY
 Iniquit
+DSFdsfWxp

core/src/mindustry/mod/Mods.java

@@ -413,19 +413,30 @@ private PageType getPage(Fi file){
 
     /** Removes a mod file and marks it for requiring a restart. */
     public void removeMod(LoadedMod mod){
-        if(!android && mod.loader != null){
-            try{
-                ClassLoaderCloser.close(mod.loader);
-            }catch(Exception e){
-                Log.err(e);
+        boolean deleted = true;
+
+        if(mod.loader != null){
+            if(android){
+                //Try to remove cache for Android 14 security problem
+                Fi cacheDir = new Fi(Core.files.getCachePath()).child("mods");
+                Fi modCacheDir = cacheDir.child(mod.file.nameWithoutExtension());
+                if(modCacheDir.exists()){
+                    deleted = modCacheDir.deleteDirectory();
+                }
+            }else{
+                try{
+                    ClassLoaderCloser.close(mod.loader);
+                }catch(Exception e){
+                    Log.err(e);
+                }
             }
         }
 
         if(mod.root instanceof ZipFi){
             mod.root.delete();
         }
 
-        boolean deleted = mod.file.isDirectory() ? mod.file.deleteDirectory() : mod.file.delete();
+        deleted &= mod.file.isDirectory() ? mod.file.deleteDirectory() : mod.file.delete();
 
         if(!deleted){
             ui.showErrorMessage("@mod.delete.error");
@@ -1112,6 +1123,11 @@ private LoadedMod loadMod(Fi sourceFile, boolean overwrite, boolean initialize)
                     //close the classloader for jar mods
                     if(!android){
                         ClassLoaderCloser.close(other.loader);
+                    }else if(other.loader != null){
+                        //Try to remove cache for Android 14 security problem
+                        Fi cacheDir = new Fi(Core.files.getCachePath()).child("mods");
+                        Fi modCacheDir = cacheDir.child(other.file.nameWithoutExtension());
+                        modCacheDir.deleteDirectory();
                     }
 
                     //close zip file