Merge pull request matthewsamuel95#687 from Orasz/binsearch-bug

matthewsamuel95 · web-flow · commit daa1e09429a3 · 2018-10-20T10:18:48.000-07:00
binsearch-bug
diff --git a/Search/BinarySearch/BinarySearch.py b/Search/BinarySearch/BinarySearch.py
@@ -1,5 +1,5 @@
 def Binary_search(arr, start_index, last_index, element):
-    mid = (int)(start_index + last_index) / 2
+    mid = (int)(start_index + (last_index - start_index)) / 2
 
     if (start_index > last_index):
         print("Element not found")
diff --git a/Search/BinarySearch/binarysearch_lightning.java b/Search/BinarySearch/binarysearch_lightning.java
@@ -20,7 +20,7 @@ public static int Binary_Search(int[] A, int data) {
 		int left = 0, right = A.length - 1;
 
 		while (left <= right) {
-			int mid = (left + right) / 2;
+			int mid = (left + (right - left)) / 2;
 			if (data > A[mid]) {
 				left = mid + 1;
 			} else if (data < A[mid]) {
diff --git a/Search/BinarySearch/bsearch.cpp b/Search/BinarySearch/bsearch.cpp
@@ -15,7 +15,7 @@ bool binary_search(int number)
 
     do
     {
-        mid = (higher + lower) / 2;
+        mid = (lower + (higher - lower)) / 2;
         if (number == myarray[mid])
         {
             std::cout << "found at pos: " << mid + 1 << std::endl;

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ bool binary_search(int number)`
`15`	`15`
`16`	`16`	`do`
`17`	`17`	`{`
`18`		`- mid = (higher + lower) / 2;`
	`18`	`+ mid = (lower + (higher - lower)) / 2;`
`19`	`19`	`if (number == myarray[mid])`
`20`	`20`	`{`
`21`	`21`	`std::cout << "found at pos: " << mid + 1 << std::endl;`