Skip to content

Test fails if you put space after 'is' and does not work with 'James' as asked. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Rhpozzo opened this issue Nov 9, 2019 · 2 comments
Closed

Test fails if you put space after 'is' and does not work with 'James' as asked. #24

Rhpozzo opened this issue Nov 9, 2019 · 2 comments
Labels
bug Something isn't working confirmed help wanted Extra attention is needed

Comments

@Rhpozzo
Copy link

Rhpozzo commented Nov 9, 2019

https://github.com/4GeeksAcademy/react-exercises/blob/7c7c73a647e86815f32eb9d7e29c620563d34006/exercises/01.2-hello-jsx/tests.js#L12

Does not pass:
Screen Shot 2019-11-09 at 11 30 26 AM

Passes:
Screen Shot 2019-11-09 at 11 32 48 AM
@alesanchezr
Copy link
Member

Yes, this issue drives me crazy.. I still don't know how to fix it.

Basically the prettier and the test are fighting each other. The prettier ads the space and the test ignores it.

@alesanchezr alesanchezr added bug Something isn't working confirmed help wanted Extra attention is needed labels Sep 11, 2020
@tommygonzaleza
Copy link
Contributor

I fixed it before, this is the PR: #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working confirmed help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alesanchezr @Rhpozzo @tommygonzaleza