Refactor child item aggregation in managers

Author: 2dust

v2rayN/ServiceLib/Manager/ActionPrecheckManager.cs

@@ -214,9 +214,10 @@ private async Task<List<string>> ValidateGroupNode(ProfileItem item, ECoreType?
             return errors;
         }
 
-        var childIds = Utils.String2List(group.ChildItems) ?? [];
+        var childIds = new List<string>();
         var subItems = await ProfileGroupItemManager.GetSubChildProfileItems(group);
         childIds.AddRange(subItems.Select(p => p.IndexId));
+        childIds.AddRange(Utils.String2List(group.ChildItems));
 
         foreach (var child in childIds)
         {

v2rayN/ServiceLib/Manager/ProfileGroupItemManager.cs

@@ -230,9 +230,10 @@ public static bool HasCycle(string? indexId, HashSet<string> visited, HashSet<st
         {
             return (new List<ProfileItem>(), profileGroupItem);
         }
-        var items = await GetChildProfileItems(profileGroupItem);
-        var subItems = await GetSubChildProfileItems(profileGroupItem);
-        items.AddRange(subItems);
+
+        var items = new List<ProfileItem>();
+        items.AddRange(await GetSubChildProfileItems(profileGroupItem));
+        items.AddRange(await GetChildProfileItems(profileGroupItem));
 
         return (items, profileGroupItem);
     }